Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus flow exporter #112442

Merged
2 commits merged into from
Feb 10, 2021
Merged

prometheus flow exporter #112442

2 commits merged into from
Feb 10, 2021

Conversation

kloenk
Copy link
Member

@kloenk kloenk commented Feb 8, 2021

Motivation for this change

add prometheus flow exporter package and module. See https://github.com/neptune-networks/flow-exporter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC: @Club-Mate-Cola

@ofborg ofborg bot requested a review from kalbasit February 8, 2021 22:16
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 112442 at 3a344f43 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:

@kloenk kloenk force-pushed the flow-exporter branch 2 times, most recently from 36f0171 to 8461274 Compare February 9, 2021 13:34
@kloenk kloenk requested a review from a user February 9, 2021 13:37
ghost
ghost approved these changes Feb 9, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I haven't tested the module

@kloenk kloenk requested a review from a user February 10, 2021 12:57
@ghost ghost merged commit 92859ff into NixOS:master Feb 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz Awaiting requested review from WilliButz

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kloenk @r-rmcgibbo