Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.nbxmpp: Fix dependency specs #112673

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

atlaua
Copy link
Contributor

@atlaua atlaua commented Feb 10, 2021

These deps are actually needed at runtime, not just for the test suite.

This presumably hasn't been noticed until now because gajim, the only
consumer of nbxmpp, already depends on all three of these packages
anyway.

However, gajim only depends on libsoup transitively through gupnp-igd, and
thus fails to build if the dependency on that is disabled by passing
enableUPnP = false.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

These deps are actually needed at runtime, not just for the test suite.

This presumably hasn't been noticed until now because gajim, the only
consumer of nbxmpp, already depends on all three of these packages
anyway.

However, gajim only depends on libsoup transitively through gupnp-igd, and
thus fails to build if the dependency on that is disabled by passing
enableUPnP = false.
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112673 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • python39Packages.nbxmpp: log was empty
3 packages built:
  • gajim
  • python37Packages.nbxmpp
  • python38Packages.nbxmpp
    File "/build/precis_i18n-1.0.0/test/test_golden.py", line 44, in check_disallow                                                                                                               input_.encode(profile)                                                                                                                                                                  LookupError: unknown encoding: UsernameCaseMapped:ToLower                                                                                                                                                                                                                                                                                                                               ----------------------------------------------------------------------                                                                                                                      Ran 56 tests in 41.704s                                                                                                                                                                                                                                                                                                                                                                 FAILED (errors=1)                                                                                                                                                                           Test failed: <unittest.runner.TextTestResult run=56 errors=1 failures=0>                                                                                                                    error: Test failed: <unittest.runner.TextTestResult run=56 errors=1 failures=0>                                                                                                           cannot build derivation '/nix/store/rlvhb299nv29x4chm89dzq8f1f3jcnxj-python3.9-nbxmpp-1.0.2.drv': 1 dependencies couldn't be built                                                          cannot build derivation '/nix/store/v7zyldb900yzl61zzn59c88p55wirhml-env.drv': 1 dependencies couldn't be built 
	```

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112673 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • python39Packages.nbxmpp: log was empty
2 packages built:
  • python37Packages.nbxmpp
  • python38Packages.nbxmpp

@atlaua
Copy link
Contributor Author

atlaua commented Feb 11, 2021

The build failure reported by @SuperSandro2000 is valid but unrelated, see #112783

@atlaua
Copy link
Contributor Author

atlaua commented Feb 11, 2021

@SuperSandro2000 By the way, you might want to tweak your script, the way it formatted the error log as a single line with tons of spaces between the messages is highly unreadable.

@atlaua
Copy link
Contributor Author

atlaua commented Feb 11, 2021

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Feb 11, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 By the way, you might want to tweak your script, the way it formatted the error log as a single line with tons of spaces between the messages is highly unreadable.

That is manually copied from my terminal which mangles new lines. Alternative is a screenshot or the terminal finally fixes that bug.

@SuperSandro2000 SuperSandro2000 merged commit 2a774f3 into NixOS:master Feb 11, 2021
@atlaua atlaua deleted the aranea/nbxmpp-deps branch February 11, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants