-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python.nbxmpp: Fix dependency specs #112673
Conversation
These deps are actually needed at runtime, not just for the test suite. This presumably hasn't been noticed until now because gajim, the only consumer of nbxmpp, already depends on all three of these packages anyway. However, gajim only depends on libsoup transitively through gupnp-igd, and thus fails to build if the dependency on that is disabled by passing enableUPnP = false.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
3 packages built:
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and are new build failure:
2 packages built:
|
The build failure reported by @SuperSandro2000 is valid but unrelated, see #112783 |
@SuperSandro2000 By the way, you might want to tweak your script, the way it formatted the error log as a single line with tons of spaces between the messages is highly unreadable. |
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
That is manually copied from my terminal which mangles new lines. Alternative is a screenshot or the terminal finally fixes that bug. |
These deps are actually needed at runtime, not just for the test suite.
This presumably hasn't been noticed until now because gajim, the only
consumer of nbxmpp, already depends on all three of these packages
anyway.
However, gajim only depends on libsoup transitively through gupnp-igd, and
thus fails to build if the dependency on that is disabled by passing
enableUPnP = false.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)