Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jrnl: 1.9.8 -> 2.7 #112684

Merged
merged 4 commits into from Feb 11, 2021
Merged

jrnl: 1.9.8 -> 2.7 #112684

merged 4 commits into from Feb 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Feb 10, 2021

Motivation for this change

Update to latest upstream release 2.7

Change log: https://github.com/jrnl-org/jrnl/releases/tag/v2.7

Also, enabled tests and migrate ansiwrap to pytestCheckHook.

asteval is a new dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Feb 10, 2021

Result of nixpkgs-review pr 112684 run on x86_64-linux 1

11 packages built:
  • av-98
  • jrnl
  • python37Packages.ansiwrap
  • python37Packages.asteval
  • python37Packages.papermill
  • python38Packages.ansiwrap
  • python38Packages.asteval
  • python38Packages.papermill
  • python39Packages.ansiwrap
  • python39Packages.asteval
  • python39Packages.papermill

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112684 run on x86_64-linux 1

11 packages built:
  • av-98
  • jrnl
  • python37Packages.ansiwrap
  • python37Packages.asteval
  • python37Packages.papermill
  • python38Packages.ansiwrap
  • python38Packages.asteval
  • python38Packages.papermill
  • python39Packages.ansiwrap
  • python39Packages.asteval
  • python39Packages.papermill

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

av-98:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@fabaff
Copy link
Member Author

fabaff commented Feb 11, 2021

Result of nixpkgs-review pr 112684 run on x86_64-linux 1

11 packages built:
  • av-98
  • jrnl
  • python37Packages.ansiwrap
  • python37Packages.asteval
  • python37Packages.papermill
  • python38Packages.ansiwrap
  • python38Packages.asteval
  • python38Packages.papermill
  • python39Packages.ansiwrap
  • python39Packages.asteval
  • python39Packages.papermill

@ofborg ofborg bot requested a review from ehmry February 11, 2021 15:58
@SuperSandro2000 SuperSandro2000 merged commit 9042f74 into NixOS:master Feb 11, 2021
@fabaff fabaff deleted the bump-jrnl branch February 12, 2021 07:19
@fabaff fabaff mentioned this pull request Feb 12, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants