Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2pd: enable on all unix platforms, enable parallel build #113020

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Feb 13, 2021

Motivation for this change
  • enable on all unix platforms
  • enable parallel build
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113020 at 4ba0b20 run on x86_64-linux 1

1 package built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/networking/i2pd/default.nix:33:3:

       |
    33 |   installPhase = ''
       |   ^
    

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113020 at 4ba0b20 run on aarch64-linux 1

1 package built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/networking/i2pd/default.nix:33:3:

       |
    33 |   installPhase = ''
       |   ^
    

@prusnak prusnak merged commit 44045bb into NixOS:master Feb 13, 2021
@prusnak prusnak deleted the i2pd branch February 13, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants