Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formiko: init at 1.4.3 #113141

Merged
merged 1 commit into from
Feb 18, 2021
Merged

formiko: init at 1.4.3 #113141

merged 1 commit into from
Feb 18, 2021

Conversation

SCOTT-HAMILTON
Copy link
Contributor

@SCOTT-HAMILTON SCOTT-HAMILTON commented Feb 14, 2021

Motivation for this change

Closes #112998

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113141 at 87f66aba run on x86_64-linux 1

1 package built:
3 suggestions:
  • warning: unused-argument

    Unused argument: pkg-config.
    Near pkgs/applications/editors/formiko/default.nix:8:3:

      |
    8 | , pkg-config
      |   ^
    
  • warning: unused-argument

    Unused argument: python3.
    Near pkgs/applications/editors/formiko/default.nix:5:3:

      |
    5 | , python3
      |   ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/applications/editors/formiko/default.nix:1:3:

      |
    1 | { stdenv
      |   ^
    

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113141 at 87f66aba run on aarch64-linux 1

1 package built:
3 suggestions:
  • warning: unused-argument

    Unused argument: pkg-config.
    Near pkgs/applications/editors/formiko/default.nix:8:3:

      |
    8 | , pkg-config
      |   ^
    
  • warning: unused-argument

    Unused argument: python3.
    Near pkgs/applications/editors/formiko/default.nix:5:3:

      |
    5 | , python3
      |   ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/applications/editors/formiko/default.nix:1:3:

      |
    1 | { stdenv
      |   ^
    

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Formiko
3 participants