Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] gnome3.gnome-autoar: 0.2.4 -> 0.3.0 #113375

Merged
merged 1 commit into from
Feb 17, 2021
Merged

[20.09] gnome3.gnome-autoar: 0.2.4 -> 0.3.0 #113375

merged 1 commit into from
Feb 17, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2020-36241.

(cherry picked from commit 58c379c)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LeSuisse
gnome3.gnome-autoar: 0.2.4 -> 0.3.0
58820d6 
Fixes CVE-2020-36241.

(cherry picked from commit 58c379c)
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Feb 17, 2021
worldofpeace
worldofpeace approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say to just patch the CVE but the changes are soo tiny even if they added features https://gitlab.gnome.org/GNOME/gnome-autoar/-/blob/master/NEWS#L1

@worldofpeace worldofpeace merged commit 5c53c72 into NixOS:release-20.09 Feb 17, 2021
@LeSuisse LeSuisse deleted the gnome-autoar-0.3.0-20.09 branch February 17, 2021 10:11
@dotlambda dotlambda mentioned this pull request Feb 27, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@dasj19 dasj19 Awaiting requested review from dasj19

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeSuisse @worldofpeace