Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upwork: 5.4.9.6 -> 5.5.0.1 #113532

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 113532 at d29bfcc9 run on x86_64-linux 1

1 package built:
2 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/misc/upwork/default.nix:38:3:

       |
    38 |   installPhase = ''
       |   ^
    
  • warning: unused-argument

    Unused argument: writeShellScript.
    Near pkgs/applications/misc/upwork/default.nix:1:65:

      |
    1 | { lib, stdenv, fetchurl, dpkg, wrapGAppsHook, autoPatchelfHook, writeShellScript
      |                                                                 ^
    

@SuperSandro2000 SuperSandro2000 merged commit a2d64c5 into NixOS:master Feb 18, 2021
@WolfangAukang WolfangAukang deleted the upwork-5.5.0.1 branch August 12, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants