Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cassandra updates #113578

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Cassandra updates #113578

merged 4 commits into from
Feb 18, 2021

Conversation

roberth
Copy link
Member

@roberth roberth commented Feb 18, 2021

Motivation for this change

Closes #113421 Closes #113422 Closes #113423 Closes #113424

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Feb 18, 2021

Result of nixpkgs-review pr 113578 at da3bd95 run on aarch64-linux 1

2 packages built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/nosql/cassandra/generic.nix:33:3:

       |
    33 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 113578 at da3bd95 run on x86_64-linux 1

2 packages built:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/nosql/cassandra/generic.nix:33:3:

       |
    33 |   installPhase = ''
       |   ^
    

Thanks @r-rmcgibbo for pointing that out
@roberth roberth marked this pull request as draft February 18, 2021 12:51
@roberth roberth marked this pull request as ready for review February 18, 2021 12:57
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113578 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • cassandra_2_1
  • cassandra_2_2
2 packages built:
  • cassandra (cassandra_3_11)
  • cassandra_3_0

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 113578 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • cassandra_2_1
  • cassandra_2_2
2 packages built:
  • cassandra (cassandra_3_11)
  • cassandra_3_0

@SuperSandro2000 SuperSandro2000 merged commit 661263d into NixOS:master Feb 18, 2021
@roberth roberth mentioned this pull request Feb 18, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment