Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell-language-server: ghc 8.10.3 -> ghc 8.10.4 #113925

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

leifhelm
Copy link
Contributor

Motivation for this change

To make things work out of the box

Things done

Change default ghc to the current one (8.10.4).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member

I wonder why I always overlook this. We should find a better way to keep this in sync.

Can you cherry-pick this change onto the haskell-updates branch and change the merge target to that branch?

@leifhelm leifhelm changed the base branch from master to haskell-updates February 21, 2021 18:31
@leifhelm
Copy link
Contributor Author

I hope I did what you asked me to do

@maralorn
Copy link
Member

Perfect!

Thank you!

Merging when ofBorg passes!

@maralorn maralorn merged commit ee2d13e into NixOS:haskell-updates Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants