Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minecraft: 2.2.1441 → 2.2.1867 #114134

Merged
merged 1 commit into from
Feb 23, 2021
Merged

minecraft: 2.2.1441 → 2.2.1867 #114134

merged 1 commit into from
Feb 23, 2021

Conversation

NeQuissimus
Copy link
Member

@NeQuissimus NeQuissimus commented Feb 23, 2021 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from cpages, infinisil and ryantm February 23, 2021 16:35
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 114134 at 8628e29 run on x86_64-linux 1

1 package built:

@SuperSandro2000 SuperSandro2000 merged commit f702b3b into NixOS:master Feb 23, 2021
@ckiee
Copy link
Member

ckiee commented Mar 1, 2021

This appears to have broken the game for me. Weird.

@ckiee ckiee mentioned this pull request Mar 1, 2021
Open
@NeQuissimus NeQuissimus mentioned this pull request Mar 1, 2021
Merged
@ckiee ckiee mentioned this pull request Apr 26, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpages cpages Awaiting requested review from cpages

@infinisil infinisil Awaiting requested review from infinisil

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NeQuissimus @r-rmcgibbo @ckiee @SuperSandro2000