Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphicsmagick: set full paths to delegates such as ghostscript #114270

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 24, 2021

The --with-frozenpaths is something that we already set
unconditionally for imagemagick and imagemagick7. Without it
graphicsmagick may not be able to find its runtime dependencies.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The --with-frozenpaths is something that we already set
unconditionally for imagemagick and imagemagick7. Without it
graphicsmagick may not be able to find its runtime dependencies.
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 24, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 114270 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • gmic-qt-krita
  • octave-jit
  • photoqt
2 packages failed to build:
  • octaveFull
  • sherpa
16 packages built:
  • darktable
  • dosbox
  • gama
  • gimpPlugins.gmic (glimpsePlugins.gmic)
  • gmic
  • gmic-qt
  • graphicsmagick
  • graphicsmagick-imagemagick-compat
  • graphicsmagick_q16
  • herwig
  • minc_widgets
  • octave
  • python37Packages.rivet
  • rivet (python38Packages.rivet)
  • python39Packages.rivet
  • thepeg

@veprbl veprbl merged commit 88237f6 into NixOS:master Mar 5, 2021
@veprbl veprbl deleted the pr/graphicsmagick_full_paths branch March 5, 2021 14:43
@veprbl veprbl removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants