netplan: init at 0.101 #114285
Merged
netplan: init at 0.101 #114285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Feb 25, 2021
pkgs/tools/admin/netplan/default.nix
Outdated
| repo = "netplan"; | ||
| rev = version; | ||
| sha256 = "bCK7J2pCQUwjZu8c1n6jhF6T/gvUGwydqAXpxUMLgMc="; | ||
| fetchSubmodules = true; |
There was a problem hiding this comment.
Netplan has no submodules.
There was a problem hiding this comment.
this is from nix-prefetch-github CannonicalLtd netplan --nix - this should not have it set to true either then, it gets copypasted from there a lot
There was a problem hiding this comment.
Please create an upstream issue about this instead of telling me.
mkg20001
force-pushed
the
netplan
branch
8 times, most recently
from
c073bfd
to
cd279b2
Compare
| repo = "netplan"; | ||
| rev = version; | ||
| hash = "sha256-bCK7J2pCQUwjZu8c1n6jhF6T/gvUGwydqAXpxUMLgMc="; | ||
| fetchSubmodules = false; |
There was a problem hiding this comment.
Settings this to false is not required and should be removed.
Comment on lines
+42
to
+43
| substituteInPlace netplan/cli/utils.py --replace "/lib/netplan/generate" "$out/lib/netplan/generate" | ||
| substituteInPlace netplan/cli/utils.py --replace "ctypes.util.find_library('netplan')" "\"$out/lib/libnetplan.so\"" |
There was a problem hiding this comment.
These two can be combined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add new package
For anyone wondering how this is useful even thought nixOS is declarative: NetworkManager isn't and so that's the perfect addition
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)