Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc8.10.x: update cabal-install version to 3.4.0.0 #114344

Closed
wants to merge 1 commit into from

Conversation

eviefp
Copy link

@eviefp eviefp commented Feb 25, 2021

Not entirely sure if this is the correct solution, but cabal-install fails on pretty much all GHC 8.10.x since its update. Is this the correct way to fix the problem?

@cdepillabout
Copy link
Member

@maralorn I vaguely remember that you were trying to fix something related to cabal-install lately?

I kind of forget what the problem was though. Was there a problem compiling cabal-install-3.4.0.0 in nixpkgs? Or was it only a problem in building with ghc-8.10?

@maralorn
Copy link
Member

Well, at the point when I was involved with that stuff cabal-install was simply not released.

But no I don‘t think that the proposed fix is the right approach here. I think the purpose of the assert here is to make sure, that the Cabal version override does not get applied to a wrong cabal-install version.

@eviefp
Copy link
Author

eviefp commented Feb 26, 2021

Well, I'm either doing something wrong, or everything (8.x) is currently broken because of this assert, because cabal-install was updated to 3.4.0.0 on hackage.

@maralorn
Copy link
Member

Yeah, cabal-install 3.4 was released. Which broke the assert as expected.

@eviefp
Copy link
Author

eviefp commented Feb 26, 2021

Okay then. Would you mind elaborating on what would be the right approach in fixing it? Or pointing me to any bit of the documentation, or a previous PR which did something similar?

@maralorn
Copy link
Member

@Vladciobanu I am limited on brain power right now. My best guess is waiting until today evening, because I am sure peti will fix it quickly in the stream.
But maybe I will have a poke at it until then. I’ll try to keep you updated.

@cdepillabout
Copy link
Member

@maralorn fixed this in #114469.

Thanks for pointing this out @Vladciobanu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants