Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.grpcio: remove cctools from build inputs #114616

Merged
merged 1 commit into from Mar 1, 2021
Merged

python3Packages.grpcio: remove cctools from build inputs #114616

merged 1 commit into from Mar 1, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Feb 28, 2021

Motivation for this change

This fixes aarch64-darwin build in #105026. Without this the strip in PATH is the one from darwin.cctools, which doesn't preserve code signatures, resulting in code that cannot run and pass pythonImportsCheckPhase.

The dependency on cctools was introduced in #44902 in 2018, but it doesn't seem to be necessary on x86_64-darwin today.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (aarch64 and x86_64)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobrik bobrik mentioned this pull request Feb 28, 2021
Merged
21 tasks
@SuperSandro2000
Copy link
Member

/rebase master

@bobrik @github-actions
python3Packages.grpcio: remove cctools from build inputs
d191f22 
This fixes `aarch64-darwin` build in NixOS#105026. Without this the `strip` in `PATH`
is the one from `darwin.cctools`, which doesn't preserve code signatures,
resulting in code that cannot run and pass `pythonImportsCheckPhase`.

The dependency on cctools was introduced in NixOS#44902 in 2018,
but it doesn't seem to be necessary on `x86_64-darwin` today.
@github-actions github-actions bot changed the base branch from staging to master February 28, 2021 16:37
@github-actions github-actions bot closed this Feb 28, 2021
@github-actions
Copy link
Contributor

Rebased, please reopen the pull request to restart CI

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 114616 run on x86_64-darwin 1

3 packages built:
  • python37Packages.grpcio
  • python38Packages.grpcio
  • python39Packages.grpcio

@SuperSandro2000 SuperSandro2000 merged commit 1f372a6 into NixOS:master Mar 1, 2021
@bobrik bobrik deleted the ivan/grpcio-darwin branch March 6, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@thefloweringash thefloweringash Awaiting requested review from thefloweringash

@danieldk danieldk Awaiting requested review from danieldk

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bobrik @SuperSandro2000