Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.grpcio: remove cctools from build inputs #114616

Merged
merged 1 commit into from Mar 1, 2021
Merged

python3Packages.grpcio: remove cctools from build inputs #114616

merged 1 commit into from Mar 1, 2021

Commits on Feb 28, 2021

  1. python3Packages.grpcio: remove cctools from build inputs 

    This fixes `aarch64-darwin` build in NixOS#105026. Without this the `strip` in `PATH`
is the one from `darwin.cctools`, which doesn't preserve code signatures,
resulting in code that cannot run and pass `pythonImportsCheckPhase`.

The dependency on cctools was introduced in NixOS#44902 in 2018,
but it doesn't seem to be necessary on `x86_64-darwin` today.
    @bobrik @github-actions
    bobrik authored and github-actions[bot] committed Feb 28, 2021
    Configuration menu
    Copy the full SHA
    d191f22 View commit details
    Browse the repository at this point in the history