-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calls: 0.2.0 -> 0.3.1, callaudiod: 0.0.4 -> 0.1.0 #114879
Conversation
Result of 2 packages built:1 suggestion:
Result of 2 packages built:1 suggestion:
|
91f7ae6
to
fb33b0b
Compare
Also I got around to running this app on my pinephone and realized So should I add phone number support to evolution-data-server by default or make it optional and override evolution-data-server just for calls. |
👍 on enabling by default, doesn't sound like a big deal in terms of closure size or anything. |
Made a separate PR for evolution phone support to target staging: #115123 These two tasks can happen separately since calls still builds ok without the change. |
ef76708
to
9d7d9f5
Compare
I'll fix the extra dependencies soon. I added a few extra after misinterpreting the checkPhase error. I don't think either cmake or |
mesonFlags = [ | ||
# docs fail to build | ||
# https://source.puri.sm/Librem5/calls/issues/99 | ||
"-Dgtk_doc=false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I left the false
here even thought it is the default value so that we remember to enable it once the issue is fixed. Which seems to be the case now.
Would need to add "devdoc"
to outputs
attribute. And gtk-doc
and docbook-xsl-nons
and one of docbook_xml_dtd_XY
(where XY
is e.g. 43
, based on the docbook warnings in the build log) to nativeBuildInputs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed this and enabled the docs. I checked the warnings, it was 43. It also needed glib(gio) to build.
CMake probably is not but Vala is likely needed for bindings. |
Thanks. |
Motivation for this change
Update callaudiod and calls. There was an api change in callaudiod, so both need to be updated at the same time, or calls won't build.
closes #111865 , both updates need to be in one PR
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)