python2Packages.requests: Unbreak #115048
Conversation
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
| @@ -33,6 +33,9 @@ buildPythonPackage rec { | |||
| pytestCheckHook | |||
| ]; | |||
|
|
|||
| # AttributeError: 'KeywordMapping' object has no attribute 'get' | |||
| doCheck = ! isPy27; | |||
There was a problem hiding this comment.
That's not a solution either.
The failing test probably points to some dependency not being compatible with Python 2.
There was a problem hiding this comment.
That error is raised in pytest, so it's not an issue for requests itself.
There was a problem hiding this comment.
I know, but means that one of the dependencies (maybe pytest) is not compatible with Python 2.
There was a problem hiding this comment.
If upstream dropped python2 support we should add the latest compatible version for python 2 to nixpkgs as long as it is needed to not have any surprises or strange breakages.
There was a problem hiding this comment.
Requests still supports it and so does the version of pytest we package for Python 2.
I just marked it broken so that I do not try to build it to often and give people a false sense that they broke something. The problem wasn't so trivial for me that I could just fix it and Python 2 is also not my top priority. |
You could have opened an issue or a separate PR where a discussion could be had.. Stop defending your bad actions. Own up to them and learn from your mistakes. |
Motivation for this change
#114768 (comment)
@SuperSandro2000
In exactly the same number of lines of code you code have fixed the problem...
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)