New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rimraf: init at 3.0.2 #115174
rimraf: init at 3.0.2 #115174
Conversation
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package failed to build and already failed to build on hydra master:
25 packages built:
The following issues got detected with the above build packages.
antora:
warning: attribute-typo Near pkgs/development/node-packages/node-env.nix:409:14:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md Near pkgs/development/node-packages/node-env.nix:409:14:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md Near pkgs/development/node-packages/node-packages.nix:62191:5:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md Near pkgs/development/node-packages/node-env.nix:401:7:
See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: unused-argument
warning: unused-argument
|
Nothing that @SuperSandro2000 reported applies to this PR. |
The tool is not smart enough to detect that. |
Motivation for this change
This adds rimraf that comes from nodePackages. The
rimraf
is commonly used in a number of other downstream packages that depend on it being a build tool.I've followed the node instructions, and the generate.sh has updated a bunch of other dependencies.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)