Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rimraf: init at 3.0.2 #115174

Merged
merged 1 commit into from Mar 6, 2021
Merged

rimraf: init at 3.0.2 #115174

merged 1 commit into from Mar 6, 2021

Conversation

CMCDragonkai
Copy link
Member

Motivation for this change

This adds rimraf that comes from nodePackages. The rimraf is commonly used in a number of other downstream packages that depend on it being a build tool.

I've followed the node instructions, and the generate.sh has updated a bunch of other dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CMCDragonkai
Copy link
Member Author

»» ~/Projects/nixpkgs
 ♖ ./result/bin/rimraf --help                                                                                                                                                    (rimraf) pts/16 20:16:00
Usage: rimraf <path> [<path> ...]

  Deletes all files and folders at "path" recursively.

Options:

  -h, --help          Display this usage info
  -G, --no-glob       Do not expand glob patterns in arguments
  -g, --glob          Expand glob patterns in arguments (default)
  --preserve-root     Do not remove '/' (default)
  --no-preserve-root  Do not treat '/' specially
  --                  Stop parsing flags

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115174 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:
  • netlify-cli: log was empty
25 packages built:
  • antora
  • emojione
  • epgstation
  • gtop
  • imgbrd-grabber
  • joplin
  • mirakurun
  • redoc-cli
  • triton
  • vimPlugins.YouCompleteMe
  • vimPlugins.coc-git
  • vimPlugins.coc-html
  • vimPlugins.coc-metals
  • vimPlugins.coc-prettier
  • vimPlugins.coc-pyright
  • vimPlugins.coc-rust-analyzer
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-tsserver
  • vimPlugins.coc-vetur
  • vscode-extensions.matklad.rust-analyzer
  • vscode-extensions.ms-python.vscode-pylance
  • vscode-extensions.vadimcn.vscode-lldb
  • wasm-text-gen
  • yaml-language-server
  • ycmd

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

antora:

warning: attribute-typo
A likely typo in dontNpmInstall argument was found, did you mean dontInstall?

Near pkgs/development/node-packages/node-env.nix:409:14:

    |
409 |       inherit dontNpmInstall preRebuild unpackPhase buildPhase;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: attribute-typo
A likely typo in preRebuild argument was found, did you mean postBuild?

Near pkgs/development/node-packages/node-env.nix:409:14:

    |
409 |       inherit dontNpmInstall preRebuild unpackPhase buildPhase;
    |              ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/attribute-typo.md
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:62191:5:

      |
62191 |     meta = {
      |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: build-tools-in-build-inputs
util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:

    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
warning: unused-argument
Unused argument: nix-gitignore.
Near pkgs/development/node-packages/node-packages.nix:3:31:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                               ^

warning: unused-argument
Unused argument: stdenv.
Near pkgs/development/node-packages/node-packages.nix:3:46:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                              ^

warning: unused-argument
Unused argument: lib.
Near pkgs/development/node-packages/node-packages.nix:3:54:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                                      ^

@CMCDragonkai
Copy link
Member Author

Nothing that @SuperSandro2000 reported applies to this PR.

@SuperSandro2000
Copy link
Member

Nothing that @SuperSandro2000 reported applies to this PR.

The tool is not smart enough to detect that.

@SuperSandro2000 SuperSandro2000 merged commit 01ab0dd into NixOS:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants