New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collection: format, fix cross-compile, cleanups, etc. #115197
collection: format, fix cross-compile, cleanups, etc. #115197
Conversation
20ae7d3
to
2e54d9b
Compare
2e54d9b
to
a20b4a8
Compare
a20b4a8
to
bdfaf83
Compare
This comment has been minimized.
This comment has been minimized.
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages marked as broken and skipped:
57 packages built:
|
This PR introduced breaking changes to the public interface of nixpkgs mixed in with trivial formatting changes and cleanups and was merged within little over 24h after all but one review (which was done before the breakage was introduced). I can sympathize with the desire to bring the attribute names in |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)