Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: format, fix cross-compile, cleanups, etc. #115197

Merged
merged 33 commits into from Mar 6, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python labels Mar 5, 2021
pkgs/development/libraries/gstreamer/bad/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/vtk/generic.nix Outdated Show resolved Hide resolved
pkgs/development/tools/wrangler/default.nix Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 force-pushed the fix-collection21 branch 2 times, most recently from 20ae7d3 to 2e54d9b Compare March 5, 2021 15:46
pkgs/development/libraries/bootil/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/prusa-slicer/super-slicer.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/vtk/generic.nix Outdated Show resolved Hide resolved
@SuperSandro2000

This comment has been minimized.

@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115197 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • linuxPackages-libre.virtualbox
  • linuxPackages_latest-libre.virtualbox
57 packages built:
  • arachne-pnr
  • bootil
  • dejagnu
  • expect
  • fmbt
  • gmad
  • gti
  • hashdeep
  • http-prompt
  • httpie
  • linuxPackages.virtualbox
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_9.virtualbox
  • linuxPackages_5_10.virtualbox
  • linuxPackages_5_11.virtualbox
  • linuxPackages_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_latest_xen_dom0.virtualbox
  • linuxPackages_latest_xen_dom0_hardened.virtualbox
  • linuxPackages_lqx.virtualbox
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_xen_dom0.virtualbox
  • linuxPackages_xen_dom0_hardened.virtualbox
  • linuxPackages_zen.virtualbox
  • monotone
  • nix-output-monitor
  • open-watcom-bin
  • pkgdiff
  • poke
  • profanity
  • python37Packages.bpython
  • python37Packages.curtsies
  • python37Packages.google-api-python-client
  • python37Packages.googleapis-common-protos
  • python37Packages.pyte
  • python38Packages.bpython
  • python38Packages.curtsies
  • python38Packages.google-api-python-client
  • python38Packages.googleapis-common-protos
  • python38Packages.pyte
  • python39Packages.bpython
  • python39Packages.curtsies
  • python39Packages.google-api-python-client
  • python39Packages.googleapis-common-protos
  • python39Packages.pyte
  • safe-rm
  • swtpm (swtpm-tpm2)
  • termtosvg
  • thefuck
  • viking
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack
  • wdiff

@SuperSandro2000 SuperSandro2000 merged commit 9675484 into NixOS:master Mar 6, 2021
@SuperSandro2000 SuperSandro2000 deleted the fix-collection21 branch March 6, 2021 03:56
@sternenseemann
Copy link
Member

This PR introduced breaking changes to the public interface of nixpkgs mixed in with trivial formatting changes and cleanups and was merged within little over 24h after all but one review (which was done before the breakage was introduced).

I can sympathize with the desire to bring the attribute names in pythonPackages in line with the upstream names and PyPi, but downstream users depend on these attributes and removing them introduces unnecessary and unmanaged breakage (for example this is how I got wind of this PR). Maybe the renames should have waited until we have alias support for pythonPackages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants