pythonPackages: Add aliases 🎉

[SuperSandro2000]

Motivation for this change

Just removing or renaming packages is not nice so I thought we want aliases for python packages. With this PR I included one package I used for testing. Most of the python-aliases.nix is copied from aliases.nix. If this PR is merged I am going to move some aliases which are currently in python-packages. I am probably not renaming all the packages though.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 116367 at d1a4de3 run on x86_64-linux 1

2 packages built successfully:

• python38Packages.gensim
• python38Packages.smart-open

1 suggestion:

• warning: unclear-gpl

  lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/development/python-modules/gensim/default.nix:40:5:

     |
  40 |     license = lib.licenses.lgpl21;
     |     ^
  

---

Result of nixpkgs-review pr 116367 at d1a4de3 run on aarch64-linux 1

2 packages built successfully:

• python38Packages.gensim
• python38Packages.smart-open

1 suggestion:

• warning: unclear-gpl

  lgpl21 is a deprecated license, check if project uses lgpl21Plus or lgpl21Only and change meta.license accordingly.

  Near pkgs/development/python-modules/gensim/default.nix:40:5:

     |
  40 |     license = lib.licenses.lgpl21;
     |     ^
  

[FRidh]

NIce work!

diff --git a/pkgs/development/interpreters/python/default.nix b/pkgs/development/interpreters/python/default.nix
index 1925089921c..0e5ebfaa4ff 100644
--- a/pkgs/development/interpreters/python/default.nix
+++ b/pkgs/development/interpreters/python/default.nix
@@ -69,7 +69,7 @@ with pkgs;
               recursivePthLoader
             ;
           };
-          aliases = self: super: lib.optionalAttrs (config.allowAliases or true) (import ../../../top-level/python-aliases.nix lib super);
+          aliases = lib.optionalAttrs (config.allowAliases or true) (import ../../../top-level/python-aliases.nix lib);
         in lib.makeScopeWithSplicing
           pkgs.splicePackages
           pkgs.newScope
diff --git a/pkgs/top-level/python-aliases.nix b/pkgs/top-level/python-aliases.nix
index 10db7748fe9..76338061ff2 100644
--- a/pkgs/top-level/python-aliases.nix
+++ b/pkgs/top-level/python-aliases.nix
@@ -16,7 +16,7 @@ let
 
   # Make sure that we are not shadowing something from
   # python-packages.nix.
-  checkInPkgs = n: alias: if builtins.hasAttr n self
+  checkInPkgs = n: alias: if builtins.hasAttr n super
                           then throw "Alias ${n} is still in python-packages.nix"
                           else alias;

[sternenseemann]

+          aliases = lib.optionalAttrs (config.allowAliases or true) (import ../../../top-level/python-aliases.nix lib);

This won't work, since aliases == {} if config.AllowAliases == false when it should be a function in that case.

[SuperSandro2000]

+          aliases = lib.optionalAttrs (config.allowAliases or true) (import ../../../top-level/python-aliases.nix lib);

This won't work, since aliases == {} if config.AllowAliases == false when it should be a function in that case.

What would be the correct syntax or does it not require any change at all?

[SuperSandro2000]

I don't fully understand why and how ofborg fails and I can't locally run the ofborg checks because I only have ~16 GB available.

[sternenseemann]

The eval error was caused by this, sorry about that. Somehow blacked out and forgot that pythonPackages also contains functions and such.

Suggested change

	removeRecurseForDerivations = alias: removeAttrs alias [ "recurseForDerivations" ];
	removeRecurseForDerivations = alias:
	if lib.isAttrs alias # removeAttrs throws in all other cases
	then builtins.removeAttrs alias [ "recurseForDerivations" ]
	else alias;

[SuperSandro2000]

I used the variant that is used in aliases.nix because I don't fully understand this part to be honest.

[sternenseemann]

The code from top level removes the attribute recurseForDerivations from an attribute set if it exists and is true. My code tries to always remove the recurseForDerivations attribute if it encounters an attribute set.

Shouldn't make a derifference in the grand scheme of things and only matters if we have sub attribute sets in pythonPackages anyways.

[jonringer]

diff LGTM

seems to work as expected:

[nix-shell:~/.cache/nixpkgs-review/pr-116367]$ nix-build ./nixpkgs/ -A python3Packages.smart_open
/nix/store/yrnw7sl5iaqb1xvyjbj0fmjny6lph37l-python3.8-smart-open-4.2.0

[nix-shell:~/.cache/nixpkgs-review/pr-116367]$ nix-build ./nixpkgs/ -A python3Packages.smart-open
/nix/store/yrnw7sl5iaqb1xvyjbj0fmjny6lph37l-python3.8-smart-open-4.2.0

[nix-shell:~/.cache/nixpkgs-review/pr-116367]$ nix-build -E 'with import ./nixpkgs { config.allowAliases = false; };  python3Packages.smart_open'
error: attribute 'smart_open' missing

       at «string»:1:58:

            1| with import ./nixpkgs { config.allowAliases = false; };  python3Packages.smart_open
             | 

[nix-shell:~/.cache/nixpkgs-review/pr-116367]$ nix-build -E 'with import ./nixpkgs { config.allowAliases = true; };  python3Packages.smart_open'
/nix/store/yrnw7sl5iaqb1xvyjbj0fmjny6lph37l-python3.8-smart-open-4.2.0