New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.python-telegram-bot: 13.0 -> 13.3 #115287
Conversation
Result of 2 packages failed to build:1 suggestion:
Result of 2 packages failed to build:1 suggestion:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, isPy3k | ||
}: | ||
|
||
buildPythonPackage rec { | ||
pname = "python-telegram-bot"; | ||
version = "13.0"; | ||
version = "13.3"; | ||
disabled = !isPy3k; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a restriction on the supported Python 3 releases.
disabled = !isPy3k; | |
disabled = pythonOlder "3.6"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't ship python 3 older than 3.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how we handle this but I have no problem with adding disableds.
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@GrahamcOfBorg build python38Packages.python-telegram-bot python39Packages.python-telegram-bot |
pkgs/development/python-modules/python-telegram-bot/default.nix
Outdated
Show resolved
Hide resolved
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
|
Motivation for this change
This is the latest version
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)My own python bot is running this currently