Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.python-telegram-bot: 13.0 -> 13.3 #115287

Merged
merged 2 commits into from Mar 7, 2021

Conversation

pingiun
Copy link
Member

@pingiun pingiun commented Mar 6, 2021

Motivation for this change

This is the latest version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

My own python bot is running this currently

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 6, 2021

Result of nixpkgs-review pr 115287 at 9d2811db run on aarch64-linux 1

2 packages failed to build:
1 suggestion:
  • warning: unclear-gpl

    lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/python-telegram-bot/default.nix:40:5:

       |
    40 |     license = licenses.lgpl3;
       |     ^
    

Result of nixpkgs-review pr 115287 at 9d2811db run on x86_64-linux 1

2 packages failed to build:
1 suggestion:
  • warning: unclear-gpl

    lgpl3 is a deprecated license, check if project uses lgpl3Plus or lgpl3Only and change meta.license accordingly.

    Near pkgs/development/python-modules/python-telegram-bot/default.nix:40:5:

       |
    40 |     license = licenses.lgpl3;
       |     ^
    

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update to license while you are on it? Looks like lgpl3Only.

The upstream repo contains tests. Just something we should keep in mind. I doubt that they would work without tweaking.

, isPy3k
}:

buildPythonPackage rec {
pname = "python-telegram-bot";
version = "13.0";
version = "13.3";
disabled = !isPy3k;
Copy link
Member

@fabaff fabaff Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a restriction on the supported Python 3 releases.

Suggested change
disabled = !isPy3k;
disabled = pythonOlder "3.6";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't ship python 3 older than 3.6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we handle this but I have no problem with adding disableds.

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
@veprbl
Copy link
Member

veprbl commented Mar 7, 2021

@GrahamcOfBorg build python38Packages.python-telegram-bot python39Packages.python-telegram-bot

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115287 run on x86_64-linux 1

2 packages built:
  • python38Packages.python-telegram-bot
  • python39Packages.python-telegram-bot

@SuperSandro2000 SuperSandro2000 merged commit 1875033 into NixOS:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants