Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-telegram-bot: 13.0 -> 13.3 #115287

Merged
merged 2 commits into from Mar 7, 2021
Merged

python3Packages.python-telegram-bot: 13.0 -> 13.3 #115287

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d774c
python3Packages.python-telegram-bot: 13.0 -> 13.3
pingiun Mar 6, 2021
5bc6536
Update pkgs/development/python-modules/python-telegram-bot/default.nix
SuperSandro2000 Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 8 additions & 4 deletions pkgs/development/python-modules/python-telegram-bot/default.nix
View file
Open in desktop
Expand Up @@ -7,25 +7,29 @@
, urllib3
, tornado
, pytest
, APScheduler
, isPy3k
}:

buildPythonPackage rec {
pname = "python-telegram-bot";
version = "13.0";
version = "13.3";
disabled = !isPy3k;
Copy link
Member

@fabaff fabaff Mar 6, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a restriction on the supported Python 3 releases.

Suggested change
disabled = !isPy3k;
disabled = pythonOlder "3.6";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't ship python 3 older than 3.6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how we handle this but I have no problem with adding disableds.


src = fetchPypi {
inherit pname version;
sha256 = "ca78a41626d728a8f51affa792270e210fa503ed298d395bed2bd1281842dca3";
hash = "sha256-dw1sGfdeUw3n9qh4TsBpRdqEvNI0SnKTK4wqBaeM1CE=";
};

checkInputs = [ pytest ];
propagatedBuildInputs = [ certifi future urllib3 tornado decorator ];
propagatedBuildInputs = [ certifi future urllib3 tornado decorator APScheduler ];

# --with-upstream-urllib3 is not working properly
postPatch = ''
rm -rf telegram/vendor
SuperSandro2000 marked this conversation as resolved.
Show resolved Hide resolved

substituteInPlace requirements.txt \
--replace 'APScheduler==3.6.3' 'APScheduler'
'';
setupPyGlobalFlags = "--with-upstream-urllib3";

Expand All @@ -36,7 +40,7 @@ buildPythonPackage rec {
meta = with lib; {
description = "This library provides a pure Python interface for the Telegram Bot API.";
homepage = "https://python-telegram-bot.org";
license = licenses.lgpl3;
license = licenses.lgpl3Only;
maintainers = with maintainers; [ veprbl pingiun ];
};
}