-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/nextcloud: Conditionally enable ImageMagick PHP extension #115372
nixos/nextcloud: Conditionally enable ImageMagick PHP extension #115372
Conversation
Huh? Why is this a |
The reason is in the discussion of the associated issue:
I have a slight preference for the In any case, I think "ImageMagick is enabled" should remain the default. If we want it changed, I can create a PR for that. |
Using
Agreed. I'd suggest to set it to |
Yes, keeping it enabled by default is a good idea. Something like |
Yup, agree with that. Sorry for missing this in the first place :) |
No problem ^^ :) |
…o services.nextcloud.nginx.enableImagemagick Enable options are preferred. Suggested here: #115372 (comment)
Motivation for this change
This adds an option that disables the ImageMagick PHP extension for NextCloud. Admins may want to do so if they don't trust ImageMagick to be secure. This fixes #115279
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)