-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cjdns-tools: init at 21.1 #115459
cjdns-tools: init at 21.1 #115459
Conversation
Result of 1 package built:2 suggestions:
Result of 1 package built:2 suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some bashism
buildPhase = '' | ||
patchShebangs tools | ||
|
||
sed -e "s|'password': 'NONE'|'password': Fs.readFileSync('/etc/cjdns.keys').toString().split('\\\\n').map(v => v.split('=')).filter(v => v[0] === 'CJDNS_ADMIN_PASSWORD').map(v => v[1])[0]|g" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is quite long. Can we break it somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure - sed doesn't like multiline
This adds cjdns-tools which is exposing the tools from $cjdns/tools/ under a command named cjdns-tools (so for ex cjdns "ping" is accessible as cjdns-tools ping <ip>) Additionally patches cjdns tools to read admin pw from /etc/cjdns.keys Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
This adds cjdns-tools which is exposing the tools from
$cjdns/tools/ under a command named cjdns-tools
(so for ex cjdns "ping" is accessible as cjdns-tools ping )
Additionally patches cjdns tools to read admin pw from /etc/cjdns.keys
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)