stdenv/darwin: allow brotli reference from curl #115498
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brotli is recently a default dependency of curl in nixpkgs.
See e3d1967 in #112947
Motivation for this change
Fix darwin stdenv build.
Stage 2 now references brotli:
Comparing master and this branch (shameless plug for my stdenv analyser), the new builds by stage are:
And libidn doesn't appear in the closure of curl, so can be omitted here.
This isn't the only solution, we could use
curlMinimal
in stage1 .Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)