Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nose-timer: 1.0.0 -> 1.0.1, python3Packages.parameterized: 0.7.5 -> 0.8.1 #115524

Merged
merged 2 commits into from Mar 26, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 9, 2021

Motivation for this change

Update nose-timer to latest upstream release 1.0.1.
Update parameterized to latest upstream release 0.8.1

Enable tests

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff fabaff changed the title @fabaff python3Packages.nose-timer: 1.0.0 -> 1.0.1, python3Packages.parameterized: 0.7.5 -> 0.8.1 python3Packages.nose-timer: 1.0.0 -> 1.0.1, python3Packages.parameterized: 0.7.5 -> 0.8.1 Mar 9, 2021
@ofborg ofborg bot requested review from Ma27 and doronbehar March 9, 2021 12:46
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115524 run on x86_64-linux 1

3 packages marked as broken and skipped:
  • python38Packages.flower
  • python38Packages.pymc3
  • python39Packages.flower
60 packages built:
  • aws-sam-cli
  • buildbot (python38Packages.buildbot)
  • buildbot-full (python38Packages.buildbot-full)
  • buildbot-ui (python38Packages.buildbot-ui)
  • git-delete-merged-branches
  • linkchecker
  • matrix-synapse
  • python38Packages.Quandl (python38Packages.quandl)
  • python38Packages.audio-metadata
  • python38Packages.aws-lambda-builders
  • python38Packages.celery
  • python38Packages.censys
  • python38Packages.cufflinks
  • python38Packages.django-raster
  • python38Packages.djmail
  • python38Packages.moto
  • python38Packages.nipype
  • python38Packages.nose-timer
  • python38Packages.parameterized
  • python38Packages.patsy
  • python38Packages.pprintpp
  • python38Packages.pybids
  • python38Packages.qiskit
  • python38Packages.qiskit-aqua
  • python38Packages.statsmodels
  • python38Packages.tbm-utils
  • python38Packages.tensorboardx
  • python38Packages.vertica-python
  • python39Packages.Quandl (python39Packages.quandl)
  • python39Packages.audio-metadata
  • python39Packages.aws-lambda-builders
  • python39Packages.celery
  • python39Packages.cufflinks
  • python39Packages.django-raster
  • python39Packages.djmail
  • python39Packages.moto
  • python39Packages.nipype
  • python39Packages.nose-timer
  • python39Packages.parameterized
  • python39Packages.patsy
  • python39Packages.pprintpp
  • python39Packages.pybids
  • python39Packages.qiskit
  • python39Packages.qiskit-aqua
  • python39Packages.statsmodels
  • python39Packages.tbm-utils
  • python39Packages.tensorboardx
  • python39Packages.vertica-python
  • sourcehut.buildsrht
  • sourcehut.dispatchsrht
  • sourcehut.gitsrht
  • sourcehut.hgsrht
  • sourcehut.hubsrht
  • sourcehut.listssrht
  • sourcehut.mansrht
  • sourcehut.metasrht
  • sourcehut.pastesrht
  • sourcehut.todosrht
  • styx
  • theharvester

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nose-timer commits can be squashed IMO, other then that, all LGTM.

@risicle
Copy link
Contributor

risicle commented Mar 22, 2021

Only rebuild failure on macos 10.14 is pybids, already broken. 👍

@fabaff fabaff force-pushed the bump-nose-timer branch 3 times, most recently from 5d245cd to 212c579 Compare March 26, 2021 08:45
@ofborg ofborg bot requested a review from doronbehar March 26, 2021 08:54
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being so pedant, but the last commit message doesn't reflect the changes made there, I think the whole PR can be squashed into two update commits, 1 for each packages.

@fabaff
Copy link
Member Author

fabaff commented Mar 26, 2021

My bad, the last commit should have gone into the update commit.

Usually I try to keep commits separated as it would allow to revert in an easy way. Thus, the update and the enabling of the tests are splitted. They are squashed now.

@ofborg ofborg bot requested a review from doronbehar March 26, 2021 10:33
@doronbehar
Copy link
Contributor

Only rebuild failure on macos 10.14 is pybids, already broken. +1

Merging.

@doronbehar doronbehar merged commit 1557783 into NixOS:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants