New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.nose-timer: 1.0.0 -> 1.0.1, python3Packages.parameterized: 0.7.5 -> 0.8.1 #115524
Conversation
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 3 packages marked as broken and skipped:
60 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nose-timer commits can be squashed IMO, other then that, all LGTM.
Only rebuild failure on macos 10.14 is |
5d245cd
to
212c579
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being so pedant, but the last commit message doesn't reflect the changes made there, I think the whole PR can be squashed into two update commits, 1 for each packages.
python3Packages.nose-timer: enable tests
My bad, the last commit should have gone into the update commit. Usually I try to keep commits separated as it would allow to revert in an easy way. Thus, the update and the enabling of the tests are splitted. They are squashed now. |
Merging. |
Motivation for this change
Update nose-timer to latest upstream release 1.0.1.
Update parameterized to latest upstream release 0.8.1
Enable tests
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)