New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lnd: 0.12.0 -> 0.12.1 #115610
lnd: 0.12.0 -> 0.12.1 #115610
Conversation
I did not edit the sha256 values in this expression. This is my first time contributing to nixpkgs and I was hoping for some guidance on what I would need to do to edit those values. |
}: | ||
|
||
buildGoModule rec { | ||
pname = "lnd"; | ||
version = "0.12.0-beta"; | ||
version = "0.12.1-beta"; | ||
|
||
src = fetchFromGitHub { | ||
owner = "lightningnetwork"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to update the hash.
Set hashes to:
Then run build and it fails, but it will print the correct values in the process. So just re-edit them and run the build again. |
And set the commit message to:
|
Build passed, hashes changed, commit message fixed. |
It seems you didn't push the modified hashes - I don't see them in c465266 |
my bad, I forgot to do a git add before amending the commit. |
@GrahamcOfBorg build lnd |
@ProofOfKeags Merged. Thanks for the contribution! |
Motivation for this change
Bump LND version to 0.12.1 and add routerrpc compile flag.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)