Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lnd: 0.12.0 -> 0.12.1 #115610

Merged
merged 1 commit into from Mar 9, 2021
Merged

lnd: 0.12.0 -> 0.12.1 #115610

merged 1 commit into from Mar 9, 2021

Conversation

ProofOfKeags
Copy link
Contributor

@ProofOfKeags ProofOfKeags commented Mar 9, 2021

Motivation for this change

Bump LND version to 0.12.1 and add routerrpc compile flag.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ProofOfKeags
Copy link
Contributor Author

I did not edit the sha256 values in this expression. This is my first time contributing to nixpkgs and I was hoping for some guidance on what I would need to do to edit those values.

}:

buildGoModule rec {
pname = "lnd";
version = "0.12.0-beta";
version = "0.12.1-beta";

src = fetchFromGitHub {
owner = "lightningnetwork";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update the hash.

@prusnak
Copy link
Member

prusnak commented Mar 9, 2021

I did not edit the sha256 values in this expression. This is my first time contributing to nixpkgs and I was hoping for some guidance on what I would need to do to edit those values.

Set hashes to:

sha256 = "0000000000000000000000000000000000000000000000000000";

vendorSha256 = "0000000000000000000000000000000000000000000000000000";

Then run build and it fails, but it will print the correct values in the process. So just re-edit them and run the build again.

@prusnak
Copy link
Member

prusnak commented Mar 9, 2021

And set the commit message to:

lnd: 0.12.0 -> 0.12.1

@ProofOfKeags
Copy link
Contributor Author

Build passed, hashes changed, commit message fixed.

@prusnak
Copy link
Member

prusnak commented Mar 9, 2021

Build passed, hashes changed, commit message fixed.

It seems you didn't push the modified hashes - I don't see them in c465266

@ProofOfKeags
Copy link
Contributor Author

my bad, I forgot to do a git add before amending the commit.

@prusnak
Copy link
Member

prusnak commented Mar 9, 2021

@GrahamcOfBorg build lnd

@prusnak prusnak merged commit 909a4ba into NixOS:master Mar 9, 2021
@prusnak prusnak changed the title LND 0.12.1 lnd: 0.12.0 -> 0.12.1 Mar 9, 2021
@prusnak
Copy link
Member

prusnak commented Mar 9, 2021

@ProofOfKeags Merged. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants