Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: 2.30.1 -> 2.30.2 #115785

Closed
wants to merge 1 commit into from
Closed

git: 2.30.1 -> 2.30.2 #115785

wants to merge 1 commit into from

Conversation

rb2k
Copy link
Contributor

@rb2k rb2k commented Mar 10, 2021

Motivation for this change

This should fix the vulnerability described in https://github.blog/2021-03-09-git-clone-vulnerability-announced/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rb2k
Copy link
Contributor Author

rb2k commented Mar 10, 2021

Waiting for my nixpkgs-review processes to finish...

(also: switching to stanging-next given the amount of packages)

@rb2k rb2k changed the base branch from master to staging-next March 10, 2021 16:12
@rb2k rb2k changed the base branch from staging-next to master March 10, 2021 16:13
@ofborg ofborg bot requested review from peti, wmertens, primeos and globin March 10, 2021 16:14
@primeos
Copy link
Member

primeos commented Mar 10, 2021

Thanks but this update is already in staging: #115597
(If deemed necessary we could consider pushing it to staging-next as well.)

@primeos primeos closed this Mar 10, 2021
@rb2k
Copy link
Contributor Author

rb2k commented Mar 10, 2021

Ahhh, I looked in the wrong place then. Great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants