-
-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/manual/writing-nixos-tests: document how to disable Black silently #115879
Conversation
e965d70
to
d3ea5a7
Compare
I actually think this is fine to use in nixpkgs if you have e.g. |
No, this is not okay, as it disables all linting for the whole file. |
There's #72964, which proposes switching to less stricter linting, so these kind of interpolations are not too much of a problem, but we shouldn't encourage disabling linting alltogether. |
Thanks for the PR! |
@flokli I thought |
@Ma27 (edited to add missing quote) |
And thanks for the suggestion @flokli! |
Ahh, I see. In that case it should indeed be avoided in nixpkgs, thanks for the clarification. |
Motivation for this change
This is following up on a request from @flokli in #96515 to add documentation for disabling the Black linter for NixOS tests without generating a warning (re. #72964).
I've built the manual with the two commands from the manual to verify the changes:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)