Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.django-cacheops: init at 5.1 #115916

Merged
merged 2 commits into from Mar 20, 2021
Merged

python3.pkgs.django-cacheops: init at 5.1 #115916

merged 2 commits into from Mar 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 11, 2021

Motivation for this change

Needed for Funkwhale

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not add an entry to python top level.

@ghost
Copy link
Author

ghost commented Mar 12, 2021

You did not add an entry to python top level.

Forgot to commit it. Fixed.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 115916 run on x86_64-linux 1

2 packages built:
  • python38Packages.django-cacheops
  • python39Packages.django-cacheops

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.django-cacheops:

warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md
warning: unused-argument
Unused argument: mock.
Near pkgs/development/python-modules/django-cacheops/default.nix:8:3:

  |
8 | , mock
  |   ^

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ghost ghost requested a review from SuperSandro2000 March 20, 2021 17:55
@SuperSandro2000 SuperSandro2000 merged commit 1042267 into NixOS:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant