Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple-music-electron: 1.5.2 -> 1.5.5 #116012

Merged
merged 1 commit into from Mar 15, 2021

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Fails with the following error without the change in pkgs/build-support/appimage/default.nix:

/nix/store/48a25nl0bpcya9pdajcwxdx4k9cjfzgr-Apple.Music-1.5.5-extracted/apple-music-electron: error while loading shared libraries: libxshmfence.so.1: cannot open shared object file: No such file or directory
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116012 run on x86_64-linux 1

1 package blacklisted:
  • appimage-run-tests
36 packages built:
  • Sylk
  • anki-bin
  • appimage-run
  • apple-music-electron
  • chrysalis
  • deltachat-electron
  • devdocs-desktop
  • electronplayer
  • irccloud
  • joplin-desktop
  • keeweb
  • ledger-live-desktop
  • lens
  • lunar-client
  • marktext
  • minetime
  • molotov
  • mycrypto
  • notable
  • nuclear
  • p3x-onenote
  • plexamp
  • radicle-upstream
  • rambox
  • rambox-pro
  • runwayml
  • ssb-patchwork
  • standardnotes
  • station
  • timeular
  • trezor-suite
  • tusk
  • unityhub
  • wootility
  • zettlr
  • zulip

@IvarWithoutBones
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Mar 14, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Mar 14, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@kevincox
Copy link
Contributor

Can you explain why the source was changed? I feel somewhat uncomfortable with approving the source change with no context. I think the commit description should include information on this new source.

@kevincox
Copy link
Contributor

Also should the homepage be updated to the new source?

@IvarWithoutBones
Copy link
Member Author

IvarWithoutBones commented Mar 15, 2021

@kevincox The old source now simply redirects to this one, I think the owner of the repository changed their account name. I'll put that in the commit description.

As for the homepage, you're right! I'll change that, good catch :)

@kevincox
Copy link
Contributor

Sounds good. I would still include that information in the commit message just to make it clear that this is the same source but it has been moved. It makes it easier for anyone else reading the commits to see what happened.

@SuperSandro2000 SuperSandro2000 merged commit 0b876ea into NixOS:master Mar 15, 2021
@IvarWithoutBones IvarWithoutBones deleted the apple-music-1.5.5 branch April 4, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants