wireshark: 3.4.3 -> 3.4.4

[TredwellGit]

Motivation for this change

https://www.wireshark.org/docs/relnotes/wireshark-3.4.4.html

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 116018 at ed2281f2 run on x86_64-linux 1

9 packages built successfully:

• compactor
• haka
• ostinato
• python38Packages.pyshark
• python39Packages.pyshark
• termshark
• wifite2
• wireshark
(wireshark-qt)
• wireshark-cli

3 suggestions:

• warning: build-tools-in-build-inputs

  makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/applications/networking/sniffers/wireshark/default.nix:40:3:

     |
  40 |   buildInputs = [
     |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/applications/networking/sniffers/wireshark/default.nix:99:5:

     |
  99 |     license = licenses.gpl2;
     |     ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/applications/networking/sniffers/wireshark/default.nix:3:33:

    |
  3 | , libssh, nghttp2, zlib, cmake, fetchpatch, makeWrapper
    |                                 ^
  

---

Result of nixpkgs-review pr 116018 at ed2281f2 run on aarch64-linux 1

8 packages built successfully:

• compactor
• ostinato
• python38Packages.pyshark
• python39Packages.pyshark
• termshark
• wifite2
• wireshark
(wireshark-qt)
• wireshark-cli

3 suggestions:

• warning: build-tools-in-build-inputs

  makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/applications/networking/sniffers/wireshark/default.nix:40:3:

     |
  40 |   buildInputs = [
     |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/applications/networking/sniffers/wireshark/default.nix:99:5:

     |
  99 |     license = licenses.gpl2;
     |     ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/applications/networking/sniffers/wireshark/default.nix:3:33:

    |
  3 | , libssh, nghttp2, zlib, cmake, fetchpatch, makeWrapper
    |                                 ^
  

[mweinelt]

@TredwellGit Can you take a look at the suggestions? They seem very spot on.

[erictapen]

Backported in 52abed1.