python3Packages.packageurl-python: init at 0.9.4 #116325
Conversation
| sha256 = "0mpvj8imsaqhrgfq1cxx16flc5201y78kqa7bh2i5zxsc29843mx"; | ||
| }; | ||
|
|
||
| pythonImportsCheck = [ "packageurl" ]; |
There was a problem hiding this comment.
| pythonImportsCheck = [ "packageurl" ]; | |
| checkInputs = [ pytestCheckHook ]; | |
| pythonImportsCheck = [ "packageurl" ]; |
There was a problem hiding this comment.
You should also try whether the tests run successfully.
There was a problem hiding this comment.
Loving it that people are giving conflicting information. Very helpful :-/
There was a problem hiding this comment.
Loving it that people are giving conflicting information. Very helpful :-/
To be a bit more constructive: the previous time I submitted it I was told to include what I included if I was not able to run tests. I am not able to run the tests at this point.
There was a problem hiding this comment.
Sorry, this was more about the missing argument pytestCheckHook.
If you post the output, we can help figure out how to make the tests run.
There was a problem hiding this comment.
I will need some help here. Note: I am not on NixOS, but Fedora. It has been 15 years since I did any serious work with Nix so my skills are very rusty.
There was a problem hiding this comment.
I get
Executing pytestCheckPhase
============================= test session starts ==============================
platform linux -- Python 3.9.2, pytest-6.1.2, py-1.9.0, pluggy-0.13.1
rootdir: /build/packageurl-python-0.9.4, configfile: setup.cfg
collected 258 items
tests/test_packageurl.py ..................................... [ 14%]
tests/contrib/test_get_path_segments.py ... [ 15%]
tests/contrib/test_purl2url.py .. [ 16%]
tests/contrib/test_url2purl.py ......................................... [ 32%]
........................................................................ [ 60%]
........................................................................ [ 87%]
............................... [100%]
============================= 258 passed in 0.84s ==============================
Finished executing pytestCheckPhase
So everything seems to work.
|
Please squash the review commit together as you can't do this from the github web ui without also squashing the maintainer add commit. |
armijnhemel
force-pushed
the
package_url
branch
from
79d274c
to
a1e2aac
Compare
| sha256 = "0mpvj8imsaqhrgfq1cxx16flc5201y78kqa7bh2i5zxsc29843mx"; | ||
| }; | ||
|
|
||
| pythonImportsCheck = [ "packageurl" ]; |
There was a problem hiding this comment.
Sorry, this was more about the missing argument pytestCheckHook.
If you post the output, we can help figure out how to make the tests run.
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 2 packages built:
The following issues got detected with the above build packages.
python38Packages.packageurl:
warning: no-python-tests |
Avoid confusion as in NixOS#116325 (comment).
dotlambda
changed the title
armijnhemel
force-pushed
the
package_url
branch
from
8f07b64
to
b1f175c
Compare
|
grrr, sorry, I thought I had changed the commit message |
packageurl: add checkInputs as suggested by review packageurl -> packageurl-python packageurl-python: add missing dependency
armijnhemel
force-pushed
the
package_url
branch
from
b1f175c
to
ef3912b
Compare
Avoid confusion as in #116325 (comment).
Motivation for this change
packageurl (AKA purl) is an upcoming standard to describe packages in a more uniform way across operating systems and Linux distributions
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)