Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pygments: 2.7.4 -> 2.8.1 #116710

Closed
wants to merge 1 commit into from

Conversation

mbrgm
Copy link
Member

@mbrgm mbrgm commented Mar 18, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pythonImportsCheck and correct the commit message.

@dotlambda dotlambda changed the title pythonPackages.pygments: 2.7.4 -> 2.8.1 python3Packages.pygments: 2.7.4 -> 2.8.1 Mar 18, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 116710 at ca8f9a24 run on x86_64-linux 1

745 packages marked as broken and skipped:
  • adobe-reader
  • agdaPackages.iowa-stdlib
  • aldor
  • aliceml
  • alliance
  • amule
  • amuleDaemon
  • amuleGui
  • aqemu
  • atom-beta
  • ...
20817 packages skipped due to time constraints:
  • AusweisApp2
  • EBTKS
  • EmptyEpsilon
  • Fabric
  • Literate
  • MIDIVisualizer
  • MMA
  • OSCAR
  • OVMF
  • OVMF-CSM
  • ...
80 packages built successfully:
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/Pygments/default.nix:25:5:

       |
    25 |     maintainers = with lib.maintainers; [ ];
       |     ^
    

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 116710 run on x86_64-linux 1

2 packages built:
  • python38Packages.pygments
  • python39Packages.pygments

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python38Packages.pygments:

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/Pygments/default.nix:25:5:

   |
25 |     maintainers = with lib.maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md
warning: python-include-tests
Add a checkPhase for tests, or at least pythonImportsCheck.

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/python-include-tests.md

@FRidh
Copy link
Member

FRidh commented Mar 24, 2021

part of #117452

@FRidh FRidh closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants