Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin: add libobjc to buildInputs of pkgs.bundlerEnv #11685

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -70,7 +70,6 @@ in
"--with-exslt-lib=${libxslt}/lib"
"--with-exslt-include=${libxslt}/include"
] ++ lib.optional stdenv.isDarwin "--with-iconv-dir=${libiconv}";
buildInputs = lib.optional stdenv.isDarwin darwin.libobjc;
};

pg = attrs: {
Expand Down Expand Up @@ -124,10 +123,6 @@ in
'';
};

unf_ext = attrs: {
buildInputs = lib.optional stdenv.isDarwin darwin.libobjc;
};

xapian-ruby = attrs: {
# use the system xapian
buildInputs = [ xapian pkgconfig zlib ];
Expand Down
15 changes: 10 additions & 5 deletions pkgs/development/interpreters/ruby/bundler-env/default.nix
@@ -1,6 +1,6 @@
{ stdenv, runCommand, writeText, writeScript, writeScriptBin, ruby, lib
, callPackage, defaultGemConfig, fetchurl, fetchgit, buildRubyGem , bundler_HEAD
, git
, git, darwin
}@defs:

# This is a work-in-progress.
Expand Down Expand Up @@ -38,10 +38,15 @@ let
src = (fetchers."${attrs.source.type}" attrs);
};

applyGemConfigs = attrs:
if gemConfig ? "${attrs.name}"
then attrs // gemConfig."${attrs.name}" attrs
else attrs;
applyGemConfigs = oldAttrs:
let
attrs = {
buildInputs = lib.optional stdenv.isDarwin darwin.libobjc;
} // oldAttrs;
in
if gemConfig ? "${attrs.name}"
then attrs // gemConfig."${attrs.name}" attrs
else attrs;

needsPatch = attrs:
(attrs ? patches) || (attrs ? prePatch) || (attrs ? postPatch);
Expand Down