Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.iaqualink: init at 0.4.0 #117013

Merged
merged 4 commits into from Mar 21, 2021
Merged

python3Packages.iaqualink: init at 0.4.0 #117013

merged 4 commits into from Mar 21, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 20, 2021

Motivation for this change

Python library for Jandy iAqualink

https://github.com/flz/iaqualink-py

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 20, 2021 •
edited

Result of nixpkgs-review pr 117013 at f5948a79 run on aarch64-linux 1

1 package failed to build (new failures):
  • home-assistant
2 packages built successfully:

Result of nixpkgs-review pr 117013 at f5948a79 run on x86_64-linux 1

1 package failed to build (new failures):
  • home-assistant
2 packages built successfully:

@fabaff
Copy link
Member Author

fabaff commented Mar 20, 2021

Result of nixpkgs-review pr 117013 run on x86_64-linux 1

2 packages built:
  • python38Packages.iaqualink
  • python39Packages.iaqualink

mweinelt
mweinelt reviewed Mar 20, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please enable the iaqualink tests in home-assistant.

@ofborg ofborg bot requested a review from mweinelt March 21, 2021 00:19
@fabaff fabaff marked this pull request as draft March 21, 2021 00:21
@mweinelt
Copy link
Member

mweinelt commented Mar 21, 2021 •
edited

Likely due to the version mismatch: 0.3.4 vs 0.4.0.

https://github.com/flz/iaqualink-py/blob/v0.3.4/src/iaqualink/__init__.py
https://github.com/flz/iaqualink-py/blob/v0.4.0/src/iaqualink/__init__.py

_______ ERROR collecting tests/components/iaqualink/test_config_flow.py ________
ImportError while importing test module '/build/source/tests/components/iaqualink/test_config_flow.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/yl69v76azrz4daiqksrhb8nnmdiqdjg9-python3-3.8.8/lib/python3.8/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/components/iaqualink/test_config_flow.py:7: in <module>
    from homeassistant.components.iaqualink import config_flow
homeassistant/components/iaqualink/__init__.py:8: in <module>
    from iaqualink import (
E   ImportError: cannot import name 'AqualinkBinarySensor' from 'iaqualink' (/nix/store/f4y8h2c176na5cvv9xx4698nfr90zndp-python3.8-iaqualink-0.4.0/lib/python3.8/site-packages/iaqualink/__init__.py)

@fabaff
Copy link
Member Author

fabaff commented Mar 21, 2021

Result of nixpkgs-review pr 117013 run on x86_64-linux 1

1 package failed to build:
  • home-assistant
2 packages built:
  • python38Packages.iaqualink
  • python39Packages.iaqualink

@mweinelt
home-assistant: pin iaqualink at 0.3.4
cfce515 
This was required due to breaking API changes in iaqualink>=0.4.0 and
can be safely removed after home-assistant/core#48137
has been merged and released.
@mweinelt mweinelt marked this pull request as ready for review March 21, 2021 03:16
@mweinelt
Copy link
Member

This should fix the tests until upstream has caught up with v0.4.0.

@mweinelt
Copy link
Member

@GrahamcOfBorg build home-assistant

@mweinelt mweinelt merged commit 355d0fc into NixOS:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @mweinelt