New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vollkorn: init at 4.105 #117096
vollkorn: init at 4.105 #117096
Conversation
Result of 1 package built successfully:1 suggestion:
Result of 1 package built successfully:1 suggestion:
|
adding a popular Serif font
in | ||
fetchzip { | ||
name = "${pname}-${version}"; | ||
url = "http://vollkorn-typeface.com/download/vollkorn-4-105.zip"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That url should contain the version variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, that happens when you completely redo a PR / 0 \ .
Does it make sense to make the follow-up on this a --fixup
commit? Or is a proper commit message preferred, as the fixup won't ever be squashed anyways`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation for this change
adding a popular Serif font. This addition should have a low maintenance burden due to low complexity and slow release schedule.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)