Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vollkorn: init at 4.105 #117096

Merged
merged 1 commit into from Mar 26, 2021
Merged

vollkorn: init at 4.105 #117096

merged 1 commit into from Mar 26, 2021

Conversation

schmittlauch
Copy link
Member

@schmittlauch schmittlauch commented Mar 21, 2021

Motivation for this change

adding a popular Serif font. This addition should have a low maintenance burden due to low complexity and slow release schedule.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/data/fonts/vollkorn/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/vollkorn/default.nix Outdated Show resolved Hide resolved
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 21, 2021

Result of nixpkgs-review pr 117096 at 430676da run on aarch64-linux 1

1 package built successfully:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/data/fonts/vollkorn/default.nix:15:3:

       |
    15 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 117096 at 430676da run on x86_64-linux 1

1 package built successfully:
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/data/fonts/vollkorn/default.nix:15:3:

       |
    15 |   installPhase = ''
       |   ^
    

adding a popular Serif font
in
fetchzip {
name = "${pname}-${version}";
url = "http://vollkorn-typeface.com/download/vollkorn-4-105.zip";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That url should contain the version variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, that happens when you completely redo a PR / 0 \ .
Does it make sense to make the follow-up on this a --fixup commit? Or is a proper commit message preferred, as the fixup won't ever be squashed anyways`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmittlauch schmittlauch restored the vollkorn branch March 26, 2021 10:50
@xaverdh xaverdh mentioned this pull request Mar 31, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants