Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vollkorn: init at 4.105 #96860

Closed
wants to merge 1 commit into from
Closed

vollkorn: init at 4.105 #96860

wants to merge 1 commit into from

Conversation

tfmoraes
Copy link
Contributor

@tfmoraes tfmoraes commented Aug 31, 2020

Motivation for this change

Add Vollkorn typeface in NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member

Vollkorn is also included in google-fonts. Not sure what is the best way to unify this; having the bundle is useful, but probably not everybody wants to install all google fonts.

pkgs/data/fonts/vollkorn/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/vollkorn/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96860 run on x86_64-linux 1

1 package built:
  • vollkorn

@tfmoraes
Copy link
Contributor Author

@SuperSandro2000 I accepted you modification but I had to remove your modifications because it was not working.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 I accepted you modification but I had to remove your modifications because it was not working.

Because it is no a mkderivation.

@SuperSandro2000
Copy link
Member

Yeah, you are right.

@xaverdh
Copy link
Contributor

xaverdh commented Mar 31, 2021

Is this obsolete now with #117096 merged?

@tfmoraes
Copy link
Contributor Author

@xaverdh I'll remove this PR.

@tfmoraes tfmoraes closed this Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants