Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocaml_extlib: 1.7.7 -> 1.7.8 #117113

Merged
merged 1 commit into from Mar 23, 2021
Merged

ocamlPackages.ocaml_extlib: 1.7.7 -> 1.7.8 #117113

merged 1 commit into from Mar 23, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Mar 21, 2021 •
edited

Supersedes #110374.

1.7.8 changed the behavior of the minimal build type (which we are
keeping as the default because opam-repository does it as well): It now
excludes the Base64 module which is prone to namespacing problems.

Since google-drive-ocamlfuse still uses the Base64 module, we need to
override it to use extlib without the minimal build type. 1.7.9 (?)
should make this obsolete as it is planned to split the Base64 module
into a separate package.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@anmonteiro @sternenseemann
ocamlPackages.ocaml_extlib: 1.7.7 -> 1.7.8
9718d7f 
1.7.8 changed the behavior of the minimal build type (which we are
keeping as the default because opam-repository does it as well): It now
excludes the Base64 module which is prone to namespacing problems.

Since google-drive-ocamlfuse still uses the Base64 module, we need to
override it to use extlib without the minimal build type. 1.7.9 (?)
should make this obsolete as it is planned to split the Base64 module
into a separate package.

Co-authored-by: sternenseemann <sternenseemann@systemli.org>
@sternenseemann
Copy link
Member Author

@ofborg build google-drive-ocamlfuse

@sternenseemann sternenseemann mentioned this pull request Mar 21, 2021
Merged
10 tasks
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 21, 2021 •
edited

Result of nixpkgs-review pr 117113 at 9718d7f run on aarch64-linux 1

3 packages built successfully:

Result of nixpkgs-review pr 117113 at 9718d7f run on x86_64-linux 1

3 packages built successfully:

@anmonteiro anmonteiro mentioned this pull request Mar 21, 2021
Closed
10 tasks
@anmonteiro
Copy link
Member

Thanks, @sternenseemann!

@vbgl
Copy link
Contributor

vbgl commented Mar 23, 2021

@GrahamcOfBorg build beluga virt-top

@vbgl vbgl merged commit 70c22f6 into NixOS:master Mar 23, 2021
@sternenseemann sternenseemann deleted the anmonteiro/extlib-1.7.8 branch March 23, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmonteiro anmonteiro anmonteiro approved these changes

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sternenseemann @r-rmcgibbo @anmonteiro @vbgl