Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgbackup: 1.1.15 -> 1.1.16 #117301

Merged
merged 4 commits into from Mar 25, 2021
Merged

borgbackup: 1.1.15 -> 1.1.16 #117301

merged 4 commits into from Mar 25, 2021

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 23, 2021 •
edited by Mic92

Motivation for this change

https://github.com/borgbackup/borg/blob/1.1.16/docs/changes.rst#version-1116-2021-03-23

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 23, 2021
@ofborg ofborg bot requested review from flokli, globin and dotlambda March 23, 2021 00:35
dotlambda
dotlambda reviewed Mar 23, 2021
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add passthru.tests?

@dotlambda
Copy link
Member

Feel free to squash commits however you see fit.

@ofborg ofborg bot requested a review from dotlambda March 23, 2021 11:18
@dotlambda
Copy link
Member

needs: port to stable

Why?

@mweinelt
Copy link
Member Author

needs: port to stable

Why?

Fair, this doesn't seem to be exactly semver, with the added features etc..

@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 23, 2021
@Mic92 Mic92 merged commit 82515ef into NixOS:master Mar 25, 2021
@mweinelt mweinelt deleted the borgbackup branch March 25, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@flokli flokli Awaiting requested review from flokli

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @dotlambda @Mic92