Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.solaredge: init at 0.0.4 #117534

Merged
merged 3 commits into from Mar 25, 2021
Merged

python3Packages.solaredge: init at 0.0.4 #117534

merged 3 commits into from Mar 25, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Mar 24, 2021

Motivation for this change

Python wrapper for Solaredge monitoring service

https://github.com/bertouttier/solaredge

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Mar 24, 2021

Result of nixpkgs-review pr 117534 run on x86_64-linux 1

3 packages built:
  • home-assistant
  • python38Packages.solaredge
  • python39Packages.solaredge

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 25, 2021 •
edited

Result of nixpkgs-review pr 117534 at 70cb86a run on aarch64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.solaredge
  • python39Packages.solaredge

Result of nixpkgs-review pr 117534 at 70cb86a run on x86_64-linux 1

3 packages built successfully:
  • home-assistant
  • python38Packages.solaredge
  • python39Packages.solaredge

@mweinelt mweinelt merged commit d9a1de3 into NixOS:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @mweinelt