Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gems: Added mime info path for mimemagic #117702

Merged
merged 3 commits into from Apr 15, 2021
Merged

gems: Added mime info path for mimemagic #117702

merged 3 commits into from Apr 15, 2021

Conversation

edude03
Copy link
Contributor

@edude03 edude03 commented Mar 26, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edude03 edude03 requested a review from alyssais as a code owner March 26, 2021 14:56
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117702 at 0c79724 run on aarch64-linux 1

2 packages skipped due to time constraints:
  • gitlab
  • gitlab-ee
2 packages built successfully:
  • iruby
  • redmine

@edude03 @SuperSandro2000
Update pkgs/development/ruby-modules/gem-config/default.nix
cba7c22 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@edude03
Copy link
Contributor Author

edude03 commented Mar 26, 2021

Thanks @SuperSandro2000, I double checked this and you're right. Not sure why it builds anyway 🤔 Looking at the code it should check that the path is a file but it doesn't.

ryantm
ryantm approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change allows it to build for me.

@ryantm ryantm merged commit bc5c0c5 into NixOS:master Apr 15, 2021
@andreykaipov
Copy link

I added the latest master branch to my channels but now I can't install. I think this PR is the issue.

error: attribute 'mimemagic' at /nix/store/pqgaklshxjj2ji6wwya38cifw4xqn4fh-master/master/pkgs/development/ruby-modules/gem-config/default.nix:397:3 already defined at /nix/store/pqgaklshxjj2ji6wwya38cifw4xqn4fh-master/master/pkgs/development/ruby-modules/gem-config/default.nix:167:3

@kylesferrazza
Copy link
Member

error: attribute 'mimemagic' at /nix/store/pqgaklshxjj2ji6wwya38cifw4xqn4fh-master/master/pkgs/development/ruby-modules/gem-config/default.nix:397:3 already defined at /nix/store/pqgaklshxjj2ji6wwya38cifw4xqn4fh-master/master/pkgs/development/ruby-modules/gem-config/default.nix:167:3

I am seeing this issue as well when trying to nix search nixpkgs/master ... after this PR.

ajs124 added a commit that referenced this pull request Apr 15, 2021
@ajs124
Revert "Merge pull request #117702 from edude03/patch-4"
692e6c9 
This reverts commit bc5c0c5, reversing
changes made to 44dac5f.
@ajs124
Copy link
Member

ajs124 commented Apr 15, 2021

I pushed a revert. This only added a duplicate redundant entry, which broke the eval.

@ajs124
Copy link
Member

ajs124 commented Apr 15, 2021

The other commit that added this was 9b30cda in #118736

@ryantm
Copy link
Member

ryantm commented Apr 15, 2021

Sorry! @ajs124 thank you for fixing it.

@nixy nixy mentioned this pull request Apr 17, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: ruby 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@edude03 @r-rmcgibbo @andreykaipov @kylesferrazza @ajs124 @ryantm @SuperSandro2000