New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] Added mime info path for mimemagic #119757
[20.09] Added mime info path for mimemagic #119757
Conversation
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 1 package marked as broken and skipped:
4 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the contributing guide when backporting commits.
I am unsure what changes are being requested here. I made a best effort attempt at following the contributing guidelines here and if I have made some mistake it isn't obvious to me. Happy to make any changes but not sure what needs to be done here. |
2c8a579
to
d369e85
Compare
The important part for this PR is https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes and especially the |
(cherry picked from commit cb7b5a0dfdf30747164204c69927df26af338111)
(cherry picked from commit 75bc87f6f89552a5f3d75588394bf261d260eabf)
Co-authored-by: Sandro <sandro.jaeckel@gmail.com> (cherry picked from commit d369e8534151fb9ebe54f1fc2e4f6fa73ff298e3)
d369e85
to
f57ce8c
Compare
This is needed to resolve #120413, so this indirectly becomes a "security" tag. ping @SuperSandro2000 please ❤️ |
Thanks! |
Motivation for this change
The fixes done to make mimemagic continue to work with Nix should be backported to the current stable version since there is currently no version of mimemagic available that can be built without these fixes.
Original commits/discussion in #117702
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)