linuxPackages: 5.4 -> 5.10

[mweinelt]

Motivation for this change

The 5.10 series is the next longterm version of the linux kernel and
I've been using it on multiple x86_64 machines ever since it came out.

I think it is time to switch over the default now, so we get some
additional testing in time for NixOS 21.05.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • boot.nix

    /nix/store/0q8g4gzm25irhiv2j9m1kp0535warf12-vm-test-run-boot-bios-cdrom
    /nix/store/4nkdszk98139f515pm8fra77gjhsmd26-vm-test-run-boot-netboot-bios
    /nix/store/w4ydxjb0p84n6y1k6qmp5mx6hc1phpg2-vm-test-run-boot-bios-usb
    /nix/store/gc8nij0x5bn4xdaigwy1nblgdf18d9sn-vm-test-run-boot-uefi-cdrom
    /nix/store/a2wwz48904pqq8q20wcnc6v03qcbd24m-vm-test-run-boot-netboot-uefi
    /nix/store/xfw73f3hcnxfbqy45q9c37j10jw5c92f-vm-test-run-boot-uefi-usb
    

  • installer.nix
    • getting error: interrupted by the user already on master, even when the terminal running the tests is not focused/visible
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[samueldr]

Approving in principle since it is the convention that at the time of branching-off, the default Linux package is the current LTS.

This is neither too soon or too late to do.

I haven't tested this change against my computers, but some were already running it, and I had been using 5.10 with Mobile NixOS previously, so I can't see it being an issue.

[NeQuissimus]

@ofborg test boot kernel-lts

[NeQuissimus]

Indeed! Thank you :)
Just kicked off ofborg to double-check the tests.

[ivan]

I am withdrawing my concern about 5.10.x, my problem looks like it was caused by a host machine reboot, likely after power loss. Sorry that I didn't check that first.

[samueldr]

The 21.05 release notes are missing! Oh my, I missed that in my first review!

[vcunat]

Unfortunately it won't build on i686: https://hydra.nixos.org/build/140600424 (reproduced locally, is one of issues blocking nixos-unstable channel)

[ajs124]

zstd: error 11 : Allocation error : not enough memory

… what?

[vcunat]

Perhaps something like this? facebook/zstd#2528 (comment)

[vcunat]

So, we simply won't use zstd in that case? #118386

[vcunat]

aaand both bonding tests got broken by this bump, too. I can reliably reproduce the issues locally – success is really fast; "failure" gets it struck forever.

In the last evaluation these are the only remaining blockers for the nixos-unstable channel (which is almost a week behind now).

[mweinelt]

Re: Upgrade from linux-lts-5.10.25 to linux-lts 5.10.26 breaks bonding.

https://www.spinics.net/lists/netdev/msg731209.html
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-rolling-lts&id=9392b8219b62b0536df25c9de82b33f8a00881ef

Not our issue! 🥳

Faulty commit was reverted in https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-rolling-lts&id=36478a9ec5afd4efd031527d0371bf8f61e5aa91, just in time for 5.10.27.

[NeQuissimus]

@mweinelt wow, nice find. I could not find any definite answer to the issue when I went looking.

#118152 contains 5.10.27

[mweinelt]

/nix/store/if2x83xbcckkqij21nh092qb2jxbr77z-vm-test-run-Bond-Networking-Networkd
/nix/store/pbpacdjcyx4z37p0ahik0qd2v3ly385s-vm-test-run-Bond-Networking-Scripted

✔️

[vcunat]

Great, with all critical tests green, we should finally get a channel update very soon.