Revert "pyre: remove" #118014
Draft
Revert "pyre: remove" #118014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa4b518.
mweinelt
reviewed
Mar 30, 2021
| @@ -10462,6 +10462,8 @@ in | |||
| ocamlPackages = ocaml-ng.ocamlPackages_4_07; | |||
| }; | |||
|
|
|||
| pyre = callPackage ../development/tools/pyre { }; | |||
There was a problem hiding this comment.
This looks like an odd place to insert it back in.
| EOF | ||
| ''; | ||
| pyre-bin = stdenv.mkDerivation { | ||
| name = "pyre-${pyre-version}"; |
There was a problem hiding this comment.
Suggested change
| name = "pyre-${pyre-version}"; | |
| pname = "pyre"; | |
| inherit version src; |
|
|
||
| ln -sf ${versionFile} ./scripts/generate-version-number.sh | ||
|
|
||
| mkdir $(pwd)/build |
There was a problem hiding this comment.
Suggested change
| mkdir $(pwd)/build | |
| mkdir build |
| homepage = https://pyre-check.org; | ||
| license = licenses.mit; | ||
| platforms = ocamlPackages.ocaml.meta.platforms; | ||
| maintainers = with maintainers; [ teh ]; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [ teh ]; | |
| maintainers = with maintainers; [ siraben ]; |
Comment on lines
+91
to
+92
| phases = [ "unpackPhase" "installPhase" ]; | ||
| installPhase = "cp -r $src $out"; |
There was a problem hiding this comment.
Suggested change
| phases = [ "unpackPhase" "installPhase" ]; | |
| installPhase = "cp -r $src $out"; | |
| installPhase = '' | |
| cp -r $src $out | |
| ''; |
Comment on lines
+96
to
+97
| version = pyre-version; | ||
| src = pyre-src; |
There was a problem hiding this comment.
Suggested change
| version = pyre-version; | |
| src = pyre-src; | |
| inherit version src; |
Comment on lines
+6
to
+7
| pyre-version = "0.0.22"; # also change typeshed revision below with $pyre-src/.typeshed-version | ||
| pyre-src = fetchFromGitHub { |
There was a problem hiding this comment.
Suggested change
| pyre-version = "0.0.22"; # also change typeshed revision below with $pyre-src/.typeshed-version | |
| pyre-src = fetchFromGitHub { | |
| version = "0.0.22"; # also change typeshed revision below with $pyre-src/.typeshed-version | |
| src = fetchFromGitHub { |
| pyre-bin = stdenv.mkDerivation { | ||
| name = "pyre-${pyre-version}"; | ||
|
|
||
| src = pyre-src; |
There was a problem hiding this comment.
Suggested change
| src = pyre-src; |
| ''; | ||
| checkPhase = '' | ||
| bash scripts/run-python-tests.sh | ||
| ''; |
There was a problem hiding this comment.
meta should be in the final package, too.
|
@siraben do you have interest in continuing this pull request? I'd like to get this packaged. |
|
Hi @mjlbach, that would be great. I haven't made progress on this PR because of the difficulty in packaging pyre's latest version. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This reverts commit fa4b518. Pyre was under constant heavy changes which put a lot of burden on maintainers (#70001). Hopefully we can get things working again on the latest version.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)