Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pysonos: fix broken checkPhase #118027

Merged
merged 2 commits into from Mar 30, 2021
Merged

python3Packages.pysonos: fix broken checkPhase #118027

merged 2 commits into from Mar 30, 2021

Conversation

elohmeier
Copy link
Contributor

Motivation for this change

checkPhase contained outdated pytest deselections.

Things done

Updated checkPhase to unbreak build.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@elohmeier elohmeier requested a review from oneingan March 30, 2021 08:53
mweinelt
mweinelt requested changes Mar 30, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider enabling the tests for the sonos component in pkgs/server/home-assistant/default.nix under componentTests in a separate commit.

pkgs/development/python-modules/pysonos/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pysonos/default.nix Show resolved Hide resolved
@elohmeier elohmeier requested a review from mweinelt March 30, 2021 12:16
@ofborg ofborg bot requested review from Mic92, dotlambda and globin March 30, 2021 12:27
@elohmeier elohmeier requested a review from mweinelt March 30, 2021 18:01
@mweinelt mweinelt merged commit 7b0b2ed into NixOS:master Mar 30, 2021
@elohmeier elohmeier deleted the pysonos_fix branch March 31, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@oneingan oneingan Awaiting requested review from oneingan

@Mic92 Mic92 Awaiting requested review from Mic92

@dotlambda dotlambda Awaiting requested review from dotlambda

@globin globin Awaiting requested review from globin

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@elohmeier @mweinelt