Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaultGemConfig.pg_query: 2.0.1 -> 2.0.2 #118296

Merged
merged 1 commit into from
Apr 3, 2021
Merged

defaultGemConfig.pg_query: 2.0.1 -> 2.0.2 #118296

merged 1 commit into from
Apr 3, 2021

Conversation

purcell
Copy link
Member

@purcell purcell commented Apr 2, 2021 •
edited
Loading

Follow-up to #116785, to apply a further small version bump for upstream fixes, including that pg_query 2.0.2 apparently should now build on ARM.

This change also re-locks my package sqlint to use the newer version, and generalises the platform spec to avoid excluding ARM.

As before, other packages which refer to pg_query (gitlab, gitlab-ee, gitaly) are unaffected, because they pin an older version of pg_query which is handled separately in the gem-config expressions.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@purcell
defaultGemConfig.pg_query: 2.0.1 -> 2.0.2
dde94e3 
pg_query 2.0.2 apparently has working ARM support.

This change also re-locks sqlint to use the newer version, and
generalises the platform spec to avoid being unnecessarily
restrictive.

As before, other packages which refer to pg_query are unaffected,
because they pin an older version of pg_query which is handled
separately in the gem-config expressions.

Follow-up to NixOS#116785
@purcell purcell requested a review from alyssais as a code owner April 2, 2021 08:04
@ofborg ofborg bot requested review from nicknovitski and ariutta April 2, 2021 08:14
@SuperSandro2000 SuperSandro2000 merged commit 1191069 into NixOS:master Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@nicknovitski nicknovitski nicknovitski approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@ariutta ariutta Awaiting requested review from ariutta

Assignees
No one assigned
Labels
6.topic: ruby 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purcell @nicknovitski @SuperSandro2000