Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dapr: 0.9.0 -> 1.0.1 #118325

Merged
merged 1 commit into from
Apr 2, 2021
Merged

dapr: 0.9.0 -> 1.0.1 #118325

merged 1 commit into from
Apr 2, 2021

Conversation

mausch
Copy link
Member

@mausch mausch commented Apr 2, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @lucperkins

@SuperSandro2000
Copy link
Member

@ofborg eval

@ofborg ofborg bot requested review from kalbasit and lucperkins April 2, 2021 16:04
SuperSandro2000
SuperSandro2000 requested changes Apr 2, 2021
View reviewed changes
pkgs/development/tools/dapr/cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/dapr/cli/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/dapr/cli/default.nix Show resolved Hide resolved
@risicle
Copy link
Contributor

risicle commented Apr 2, 2021

Builds & runs, linux x86_64.

@mausch
Copy link
Member Author

mausch commented Apr 2, 2021

I've inlined all values now, please see c7900f0

@SuperSandro2000 SuperSandro2000 merged commit 5fba338 into NixOS:master Apr 2, 2021
@mausch mausch mentioned this pull request Apr 5, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@lucperkins lucperkins Awaiting requested review from lucperkins

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mausch @SuperSandro2000 @risicle