haskellPackages.taskell: jailbreak and dontCheck

[koslambrou]

Motivation for this change

haskellPackages.taskell won't compile. Jailbreak and dontCheck

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[sternenseemann]

Thank you for fixing this up! I've checked locally and the dontCheck isn't actually necessary because the test suite succeeds.

Can you please also do the following fixups additionally:

• Remove taskell from the broken-packages list in pkgs/development/haskell-modules/configuration-hackage2nix.yaml. Otherwise the package will remain marked as broken.
• Remove the dontCheck: Doesn't seem to be necessary and we try to run test suites if possible.
• Add a short comment above the override describing why it was introduced and link a GitHub issue for taskell where the issue with the version bounds is described (if there is none it'd be great if you could open one). This helps to check when the override can be removed again!

[sternenseemann]

Oh and also this should go into configuration-common.nix

[sternenseemann]

I've done the remaining fixups for you in a83c45c, so we don't miss the haskell-updates merge this evening due to another roundtrip :)

Thanks for submitting this PR!

[koslambrou]

@sternenseemann Thanks for the merge! I'll create an issue in taskell

[sternenseemann]

No need, already done!

…

On 2. Apr 2021, at 18:48, koslambrou ***@***.***> wrote:  @sternenseemann Thanks for the merge! I'll create an issue in taskell — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.