dropbox: 3.12.4 -> 3.12.5; libGL fix #11835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pyqt for cases where libGL is not on LD_LIBRARY_PATH, e.g. with plain nixpkgs. fixes NixOS#11728
|
@bendlas Thanks, I was just about to start working on this myself! :) |
| ''; | ||
| ## FIXME: should libGL be on RPATH of qt, instead of being wrapped here? |
There was a problem hiding this comment.
@bendlas The answer to this question is "no," because Qt loads libGL dynamically (dlopen). Not all features of Qt require it, and upstream wants it to work even if libGL can't be found at runtime. However, I should suffix it to Qt's default LD_LIBRARY_PATH.
|
I already committed the Dropbox update and libGL fix to stable. For master, I am going to fix Qt's libGL issue, so I will push the Dropbox update only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.